Files
rickandCursor 133f7082cf fix(sensor): reject implausible temperature readings
An uninitialised probe reports -128 (0x80 read as a signed 8-bit
integer) while the refrigeration starts up. The cloud API relays it
verbatim and the sensor reported it as a real measurement, polluting
history graphs and long-term statistics.

Readings outside -20..50 C are now treated as firmware sentinels and
the sensor reports no value, so the state is 'unknown' and the recorder
excludes it. A range check is used rather than matching -128 exactly so
sibling sentinels are caught too. Both temperature fields are validated;
previously the details.temperature fallback was used unconditionally.

The sensor deliberately reports 'unknown' rather than going unavailable:
the coordinator poll succeeded and only the reading is missing, which
matches how every other sensor here signals absent data.

Logic lives in a new HA-free temperature.py so it can be unit-tested
without the Home Assistant harness, following the keg_detection.py
precedent.

Refs: Falkvinge/hassio-integration-perfectdraft-pro#4
Co-authored-by: Cursor <cursoragent@cursor.com>
2026-09-06 16:11:07 +02:00

43 lines
1.6 KiB
Python

"""Pure temperature extraction logic — no Home Assistant dependencies.
Kept import-free so the validation can be unit-tested standalone,
without a Home Assistant test harness.
"""
from __future__ import annotations
from typing import Any
# Readings outside this closed range are firmware sentinels, not measurements.
# An uninitialised probe reports -128 (0x80 read as a signed 8-bit integer)
# while the refrigeration starts up, and the cloud API relays it verbatim.
TEMP_MIN_PLAUSIBLE = -20.0
TEMP_MAX_PLAUSIBLE = 50.0
def plausible_temperature(value: Any) -> float | None:
"""Return ``value`` as a float when it could be a real reading, else None."""
if value is None:
return None
try:
temp = float(value)
except (TypeError, ValueError):
return None
if not TEMP_MIN_PLAUSIBLE <= temp <= TEMP_MAX_PLAUSIBLE:
return None
return temp
def beer_temperature(details: dict) -> float | None:
"""Pick the beer temperature out of a machine's ``details`` payload.
Prefers ``displayedBeerTemperatureInCelsius`` and falls back to
``temperature``. An implausible or zero displayed value falls through to
the fallback rather than short-circuiting, so a sane fallback still wins
over a sentinel. Zero is rejected on the displayed field only, matching a
firmware that reports 0 before the probe initialises.
"""
displayed = plausible_temperature(details.get("displayedBeerTemperatureInCelsius"))
if displayed is not None and displayed != 0:
return displayed
return plausible_temperature(details.get("temperature"))