3.7 KiB
3.7 KiB
1. Name and worktrees
- 1.1 Ask MThomas564 on PR #10 whether the keg or the PerfectDraft app calls 48180 "Camden Stout" or "Camden Nitro Stout"; record the answer (or "no reply by release, shipping Camden Stout") in this file
- Asked 2026-11-07: https://github.com/Falkvinge/hassio-integration-perfectdraft-pro/pull/10#issuecomment-6706008826
- Answer 2026-11-07 11:13 UTC: the PerfectDraft app shows "Camden Stout" (the store lists "Camden Nitro Stout"); the catalog follows the app, so "Camden Stout" stands
- 1.2
scripts/agent-worktree.sh create add-keg-48180in the integration repo, and an equivalent.worktree/add-keg-48180on branchagent/add-keg-48180inHassio-PerfectDraftPro-Component; confirm.agent-lockin both
2. Integration catalog
- 2.1 Add
"48180": "<name from 1.1>"tokeg_catalog.jsonas the last key, after48134 - 2.2 Ratchet
MINIMUM_ENTRIESto 117 intests/test_keg_catalog.pyand assertcatalog["48180"]; verifypython3 -m unittest tests.test_keg_catalogpasses (117 keys, ascending order) - 2.3 Change the README catalog count from 116 to 117 in place, touching no other table cell or padding; verify
git diff README.mdis a single-line change - 2.4 Commit with
Co-authored-by: MThomas564(address from his PR #10 commit); do not touchmanifest.json
3. Companion card
Work in Hassio-PerfectDraftPro-Component.
- 3.1 Take
src/assets/kegs/camden-stout.webpfrom card PR #2's head commit unchanged - 3.2 Add the
camden-stoutentry (name from 1.1, Camden Town Brewery, Stout, PR #2 colours,imagePath: kegImage("camden-stout"),kegId: "48180") next to the other Camden rows; check the ABV against Camden's or PerfectDraft's product page and use that value- ABV 4.0% confirmed on Camden Town Brewery's "Camden X PerfectDraft Stout" listing (camdentownbrewery.com, 2026-11-07), which also calls the keg "Camden Stout"
- 3.3 Re-sync
scripts/keg-catalog.reference.jsonfrom the integration commit in 2.4 and set_upstreamCommitto it - 3.4 Bump
package.json,CARD_VERSIONandEDITOR_VERSIONto 0.4.4; regeneratepackage-lock.jsonwithnpm install --package-lock-onlyrather than copying PR #2's - 3.5
npm run lint,npm run check:catalog(117/117),npm run build; commit source anddist/withCo-authored-by: MThomas564
4. Joint verification
Deferred: shipping without on-device checks
Maintainer decision, 2026-11-07: ship card 0.4.4 and the 48180 catalog entry without this check (no time for a Home Assistant reinstall), as with fix-cognito-signin 5.2–5.4. Coverage at release: catalog unit tests (117 keys, ordering), npm run lint, npm run check:catalog (117/117) and a clean npm run build with the artwork in dist/. The open TODO is in PROJECT_HYGIENE.md.
- 4.1 With
fix-cognito-signinalso applied, install integration 0.4.4 and card 0.4.4 on Home Assistant; if a 48180 keg is unavailable, confirm instead that the card editor's beer picker lists the new entry with its artwork, and thatgetBeerByKegId("48180")resolves it in a browser console on the dashboard
Workflow follow-up
- Before archiving this change, archive
add-keg-47792(complete since v0.3.4, never archived), so theentitiesmain spec reads 116 before this delta lifts it to 117. - Joint release: integration v0.4.4 (with
fix-cognito-signin) and card v0.4.4, published together. The release notes thank MThomas564 and tell users to update both. - After the release, close PR #10, card PR #2 and issue #9, each with a thank-you, the commit links and the release link.
- Archive per
AGENTS.mdin both repos (merge, push, sync theentitiesspec, archive, remove worktrees and branches).