From 8d3262a17161256ccac79ccffcac17ad84809986 Mon Sep 17 00:00:00 2001 From: Rick Falkvinge Date: Wed, 6 Jan 2016 11:52:26 +0100 Subject: [PATCH] Protection against tx dupes --- Site5/Pages/v5/Financial/Donate.aspx.cs | 29 ++++++++++++++++++++++--- 1 file changed, 26 insertions(+), 3 deletions(-) diff --git a/Site5/Pages/v5/Financial/Donate.aspx.cs b/Site5/Pages/v5/Financial/Donate.aspx.cs index 0b56a009..e8decfad 100644 --- a/Site5/Pages/v5/Financial/Donate.aspx.cs +++ b/Site5/Pages/v5/Financial/Donate.aspx.cs @@ -100,11 +100,20 @@ namespace Swarmops.Frontend.Pages.v5.Financial // TODO: Update the HotBitcoinAddress with the new amount? - Int64 satoshisReceived = unspents.Last().AmountSatoshis; + HotBitcoinAddressUnspent unspent = null; + Int64 satoshisReceived = 0; - if (unspents.Last().TransactionHash != txHash && txHash.Length > 0) + foreach (HotBitcoinAddressUnspent potentialUnspent in unspents) + { + if (potentialUnspent.TransactionHash == txHash) + { + satoshisReceived = potentialUnspent.AmountSatoshis; + unspent = potentialUnspent; + } + } + + if (unspent == null) // Supplied transaction hash was not found in collection { - // Race condition. Debugger.Break(); } @@ -117,6 +126,20 @@ namespace Swarmops.Frontend.Pages.v5.Financial // Create success message and ledger transaction string successMessage = string.Empty; + FinancialTransaction testTransaction = null; + try + { + testTransaction = FinancialTransaction.FromBlockchainHash (authData.CurrentOrganization, txHash); + + // We've already seen this donation! Something is seriously bogus here + Debugger.Break(); + return new AjaxCallResult() { DisplayMessage = successMessage, Success = true }; + } + catch (ArgumentException) + { + // This exception is expected - the transaction should not yet exist + } + if (authData.CurrentOrganization.Currency.IsBitcoin) { // The ledger is native bitcoin, so units are Satoshis