openspec(add-oktoberfest-keg-art): ship without on-device check 4.1 (maintainer decision)

Co-authored-by: Cursor <cursoragent@cursor.com>
This commit is contained in:
2026-11-07 12:36:07 +01:00
co-authored by Cursor
parent 7f7ac13fda
commit 5e1f790420
2 changed files with 5 additions and 3 deletions
+1 -1
View File
@@ -197,7 +197,7 @@ When the user corrects your approach, append a one-line rule here before ending
- **`test_harness.py` is stale: it reads `user_id` from `.credentials.json`, which now holds `email` / `access_token` / `id_token` / `refresh_token`.** It exits before doing anything useful. Fix the key names (and refresh the token per the README's reCAPTCHA step) before relying on it.
- **All five files in `openspec/specs/` fail `openspec validate --specs`** for a missing `## Purpose` section. Pre-existing and repo-wide as of 2026-09-06, so a failing spec validation is not necessarily caused by your change — check whether the error is only the Purpose one before chasing it.
- **TODO — verification debt from `fix-cognito-signin` (v0.4.4 shipped without on-device checks, maintainer decision 2026-11-07).** The Cognito direct sign-in was verified only by the automated suite (stdlib API tests and pytest config-flow tests) and the README token was checked in Firefox and Chromium; no sign-in reached the live service from Home Assistant. When there is time for a reinstall: (1) add the integration from scratch with a README token and confirm sensors populate; (2) a wrong password must return to the email/password form with `invalid_credentials` and Cognito's reason, and a token older than 2 minutes must stay on the token step with `token_rejected`; (3) trigger a reauth and confirm it succeeds (with a keg fitted, this also clears the Keg Freshness TODO above). Details in the archived change's `tasks.md`, section "Deferred".
- **TODO — verification debt from `add-keg-48180` (card 0.4.4 shipped without an on-device check, maintainer decision 2026-11-07).** Do it together with the `fix-cognito-signin` checks above: on a dashboard with card 0.4.4, confirm the card editor's beer picker lists Camden Stout with its artwork; with a 48180 keg fitted, confirm the Keg sensor reads "Camden Stout" and the card brands it.
- **TODO — verification debt from `add-keg-48180` and `add-oktoberfest-keg-art` (card 0.4.4 and 0.4.5 shipped without on-device checks, maintainer decisions 2026-11-07).** Do it together with the `fix-cognito-signin` checks above, on integration and card 0.4.5 or later: confirm the card editor's beer picker shows artwork for Camden Stout, Löwenbräu Oktoberfestbier and Spaten Oktoberfestbier, and that the two Oktoberfest images are sharp in the `hero` layout. With a 48180 keg fitted, confirm the Keg sensor reads "Camden Stout" and the card brands it. With a 29745 keg fitted, the sensor must read "Löwenbräu Oktoberfestbier" (with umlauts).
- **TODO — main specs fail `openspec validate --specs --strict` (all 5, pre-existing; seen 2026-11-07).** None of `openspec/specs/*/spec.md` has the `## Purpose` / `## Requirements` headers the current CLI requires; requirements start directly at `### Requirement:`. Archiving still works, but sync tooling and validation expect the headers. Fix in one housekeeping commit: add a short `## Purpose` and a `## Requirements` heading to each spec, then re-run strict validation.
- **TODO — own OpenSpec change: persist Cognito-refreshed tokens back to the config entry.** `PerfectDraftApiClient.refresh_access_token()` updates `_access_token`/`_id_token` in memory only, so every HA restart reloads the stale access token and burns a wasted 401-plus-refresh round trip before the first successful poll. Harmless today because the refresh token is what actually gates reauth and Cognito's `REFRESH_TOKEN_AUTH` never issues a new one, so nothing is lost — just wasteful. Deferred out of `fix-reauth-flow` to keep that diff surgical.
- **TODO — housekeeping, after `fix-cognito-signin` / `add-keg-48180` ship: take the GitHub token out of the `github` remote URLs** in both this repo and `Hassio-PerfectDraftPro-Component`. Not a leak (never committed; `.git/` is untracked), but `git remote -v` prints it. Order matters: first change `credential.helper` to an **absolute** path (`store --file=/home/rick/Lab/Dev/<repo>/.git/credentials`) — the current relative `.git/credentials` resolves against the worktree root, where `.git` is a file, so pushes from `.worktree/<topic>` only reach `github` (whose URL carries the token); pushing to `origin` from a worktree fails with "unable to open .git/credentials: Not a directory". Until fixed, push agent branches from the main checkout: `git push origin agent/<topic>` (no branch switch needed). Then strip the URL, run `git ls-remote github` from a worktree to prove auth, and update the `AGENTS.md` helper command to the absolute form.
@@ -24,9 +24,11 @@ Work in `Hassio-PerfectDraftPro-Component`.
- [x] 3.5 `npm run lint`, `npm run check:catalog` (117/117, snapshot at the 2.3 commit) and `npm run build`; verify both `.webp` files are in `dist/kegs/`, then commit source and `dist/`
- Lint clean; `check:catalog` 117/117 @ `1598e7b0`; build copies both files to `dist/kegs/`; bundle has both `imagePath`s and no `0.4.4`. Card commit `a79173a`
## 4. Joint verification
## Deferred: shipping without on-device checks
- [ ] 4.1 Install integration 0.4.5 and card 0.4.5 on Home Assistant; confirm the card editor's beer picker shows artwork for both Oktoberfest entries and that each renders sharply in the `hero` layout; with a 29745 or 33918 keg unavailable, also confirm `getBeerByKegId("29745")` and `getBeerByKegId("33918")` return entries with an `imagePath` in a browser console on the dashboard
Maintainer decision, 2026-11-07: ship integration and card 0.4.5 without this check, as with 0.4.4 (no Home Assistant on the dev host). Coverage at release: catalog unit tests (117 keys, the new 29745 name), `npm run lint`, `npm run check:catalog` (117/117), a clean `npm run build` with both images in `dist/kegs/`, and a visual check of both encoded images. The open TODO is in `PROJECT_HYGIENE.md`.
- 4.1 Install integration 0.4.5 and card 0.4.5 on Home Assistant; confirm the card editor's beer picker shows artwork for both Oktoberfest entries and that each renders sharply in the `hero` layout; with a 29745 or 33918 keg unavailable, also confirm `getBeerByKegId("29745")` and `getBeerByKegId("33918")` return entries with an `imagePath` in a browser console on the dashboard
## Workflow follow-up