Housekeeping: Removed Database warnings

This commit is contained in:
Rick Falkvinge
2017-12-04 15:59:50 +01:00
parent ac39191cc7
commit 4a2e8c6fb8
12 changed files with 19 additions and 24 deletions
-2
View File
@@ -56,8 +56,6 @@ namespace Swarmops.Database
{
if (reader.Read())
{
DateTime testDate = reader.GetDateTime (3);
return reader.GetDouble(2);
}
@@ -30,7 +30,6 @@ namespace Swarmops.Database
int foreignId = reader.GetInt32 (3);
DateTime dateTime = reader.GetDateTime (4);
int personId = reader.GetInt32 (5);
double amount = reader.GetDouble (6); // not yet used
return new BasicFinancialValidation (financialValidationId, validationType, personId, dateTime,
dependencyType, foreignId);
+1 -1
View File
@@ -25,7 +25,7 @@ namespace Swarmops.Database
int inboundInvoiceId = reader.GetInt32 (0);
int organizationId = reader.GetInt32 (1);
DateTime createdDateTime = reader.GetDateTime (2);
int createdByPersonId = reader.GetInt32 (3);
// int createdByPersonId = reader.GetInt32 (3); // TODO: Do we care about this field?
DateTime dueDate = reader.GetDateTime (4);
Int64 amountCents = reader.GetInt64 (5);
int budgetId = reader.GetInt32 (6);
-2
View File
@@ -387,8 +387,6 @@ namespace Swarmops.Database
throw new ArgumentOutOfRangeException ("OrganizationId cannot be 0");
}
List<BasicParticipation> result = new List<BasicParticipation>();
using (DbConnection connection = GetMySqlDbConnection())
{
connection.Open();
+1 -1
View File
@@ -183,7 +183,7 @@ namespace Swarmops.Database
DbCommand command =
GetDbCommand (
"SELECT * FROM CredentialsTests", connection);
DbDataReader reader = command.ExecuteReader();
command.ExecuteReader();
return true;
}
-1
View File
@@ -117,7 +117,6 @@
<Compile Include="Database-Payroll.cs" />
<Compile Include="Database-PayrollAdjustments.cs" />
<Compile Include="Database-People.cs" />
<Compile Include="Database-PirateWebLog.cs" />
<Compile Include="Database-Positions.cs" />
<Compile Include="Database-PostalCodes.cs" />
<Compile Include="Database-PostalCodesCities.cs" />
+2 -2
View File
@@ -148,8 +148,8 @@ namespace Swarmops.Logic.Communications
ForwardMessage (from, to, subject, body);
msg.ReplyMessage +=
"\r\nDitt meddelande har vidarebefordrats till medlemsservice@piratpartiet.se. Kontakta oss om du undrar över något.";
PWLog.Write (PWLogItem.None, 0, PWLogAction.SMSHandled, "Forwarded SMS from " + msg.FromNumber + " to " + to,
msg.Message + "\r\n" + msg.ErrorMessage);
//PWLog.Write (PWLogItem.None, 0, PWLogAction.SMSHandled, "Forwarded SMS from " + msg.FromNumber + " to " + to,
// msg.Message + "\r\n" + msg.ErrorMessage);
return true;
}
-1
View File
@@ -422,7 +422,6 @@
<Compile Include="Support\LogicServices.cs" />
<Compile Include="Support\Optimizations.cs" />
<Compile Include="Support\Persistence.cs" />
<Compile Include="Support\PWLog.cs" />
<Compile Include="Support\PirateWebDebug.cs" />
<Compile Include="Support\QuotedPrintable.cs" />
<Compile Include="Support\SerializableDictionary.cs" />
+3 -3
View File
@@ -18,7 +18,7 @@ namespace Swarmops.Logic.Support
0,
string.Empty);
p.TerminateActivist();
PWLog.Write (PWLogItem.Person, p.Identity, PWLogAction.ActivistLost, "Lost as activist", string.Empty);
//PWLog.Write (PWLogItem.Person, p.Identity, PWLogAction.ActivistLost, "Lost as activist", string.Empty);
}
@@ -34,8 +34,8 @@ namespace Swarmops.Logic.Support
0,
string.Empty);
newActivist.CreateActivist (isPublic, isConfirmed);
PWLog.Write (newActivist, PWLogItem.Person, newActivist.Identity, PWLogAction.ActivistJoin,
"New activist joined.", logMessage);
//PWLog.Write (newActivist, PWLogItem.Person, newActivist.Identity, PWLogAction.ActivistJoin,
// "New activist joined.", logMessage);
}
}
}
+4 -2
View File
@@ -284,8 +284,10 @@ namespace Swarmops.Logic.Swarm
{
if (this.executor != null && ("" + oldVal).Trim() != ("" + newVal).Trim())
{
PWLog.Write (this.executor, PWLogItem.Person, this.person.Identity, PWLogAction.PersonFieldChange,
this.actionDescr, "", field, "" + oldVal, "" + newVal);
//PWLog.Write (this.executor, PWLogItem.Person, this.person.Identity, PWLogAction.PersonFieldChange,
// this.actionDescr, "", field, "" + oldVal, "" + newVal);
// TODO: New log format
}
}
+2 -2
View File
@@ -197,8 +197,8 @@ namespace Swarmops.Logic.Swarm
// REMOVED: everything Roles related; being phased out
PWLog.Write (actingPerson.Identity, PWLogItem.Person, Person.Identity, PWLogAction.MemberLost,
eventSource + ":" + description, string.Empty);
//PWLog.Write (actingPerson.Identity, PWLogItem.Person, Person.Identity, PWLogAction.MemberLost,
// eventSource + ":" + description, string.Empty);
PWEvents.CreateEvent (EventSource.PirateWeb, EventType.LostMember, actingPerson.Identity, OrganizationId, Person.GeographyId,
Person.Identity, 0, OrganizationId.ToString());
+6 -6
View File
@@ -127,10 +127,10 @@ namespace Swarmops.Utility.BotCode
membership.Organization.Name + ".");
SendReminderMail (membership);
Console.Write (".");
PWLog.Write (PWLogItem.Person, membership.PersonId,
/*PWLog.Write (PWLogItem.Person, membership.PersonId,
PWLogAction.MembershipRenewReminder,
"Mail was sent to " + membership.Person.Mail +
" reminding to renew membership in " + membership.Organization.Name + ".", string.Empty);
" reminding to renew membership in " + membership.Organization.Name + ".", string.Empty);*/
Console.Write (".");
@@ -148,9 +148,9 @@ namespace Swarmops.Utility.BotCode
string logText = "FAILED sending mail to " + membership.Person.Mail +
" for reminder of pending renewal in " + membership.Organization.Name + ".";
failedReminders.Add (membership.Person.Canonical);
PWLog.Write (PWLogItem.Person, membership.PersonId,
/*PWLog.Write (PWLogItem.Person, membership.PersonId,
PWLogAction.MembershipRenewReminder,
logText, string.Empty);
logText, string.Empty);*/
ExceptionMail.Send (new Exception (logText, x));
}
}
@@ -301,10 +301,10 @@ namespace Swarmops.Utility.BotCode
try
{
SendReminderMail (membership);
PWLog.Write (PWLogItem.Person, membership.PersonId,
/*PWLog.Write (PWLogItem.Person, membership.PersonId,
PWLogAction.MembershipRenewReminder,
"Mail was sent to " + membership.Person.Mail +
" reminding to renew membership in " + membership.Organization.Name + ".", string.Empty);
" reminding to renew membership in " + membership.Organization.Name + ".", string.Empty);*/
}
catch (Exception ex)
{